refactor: add tag and relation methods to node to enforce integrity

cmd/add.go

@@ -18,38 +18,53 @@ var cTags, cRels []string
 var addCmd = &cobra.Command{
 	Use: "add <title>", Short: "Create a new node", Args: cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		if !slices.ContainsFunc(cTags, func(e string) bool { return strings.HasPrefix(e, "_type::") }) {
-			cTags = append(cTags, "_type::issue")
-		}
-		if slices.Contains(cTags, "_type::issue") && !slices.ContainsFunc(cTags, func(e string) bool { return strings.HasPrefix(e, "_status::") }) {
-			cTags = append(cTags, "_status::open")
+		svc, err := service.GetNodeService(cfg)
+		if err != nil {
+			fmt.Fprintln(os.Stderr, "failed to create:", err)
 		}
 
+		// default relations
+		if !slices.ContainsFunc(cRels, func(e string) bool { return strings.HasPrefix(e, "_namespace::") }) {
+			cRels = append(cRels, "_namespace::"+cfg.GetUser())
+		}
+
+		// parse relations
 		rels := make(map[models.RelType][]string)
-		relNamespace := false
 		for _, r := range cRels {
-			rt, tgt, err := parseRelFlag(r)
+			rel, err := parseRelFlag(svc, r)
 			if err != nil {
 				fmt.Fprintln(os.Stderr, err)
 				return
 			}
-			if rt == models.RelInNamespace {
-				relNamespace = true
-			}
-			rels[rt] = append(rels[rt], tgt)
-		}
-		if !relNamespace {
-			rels[models.RelInNamespace] = append(rels[models.RelInNamespace], cfg.GetUser())
+			rels[rel.Type] = append(rels[rel.Type], rel.Target)
 		}
 
-		svc, err := service.GetNodeService(cfg)
+		// create
+		n, err := svc.Create(args[0], cContent, cDue, nil, rels)
 		if err != nil {
 			fmt.Fprintln(os.Stderr, "failed to create:", err)
-		} else if n, err := svc.Create(args[0], cContent, cDue, cTags, rels); err != nil {
-			fmt.Fprintln(os.Stderr, "failed to create:", err)
-		} else {
-			output.PrintNode(cmd.OutOrStdout(), svc, n, jsonFlag)
+			return
 		}
+
+		for _, t := range cTags {
+			n.AddTag(t)
+		}
+
+		// default tags
+		if !slices.ContainsFunc(cTags, func(e string) bool { return strings.HasPrefix(e, "_type::") }) {
+			n.AddTag("_type::issue")
+		}
+		if n.HasTag("_type::issue") && !slices.ContainsFunc(cTags, func(e string) bool { return strings.HasPrefix(e, "_status::") }) {
+			n.AddTag("_status::open")
+		}
+
+		// persist tags added above
+		if err := svc.Update(n); err != nil {
+			fmt.Fprintln(os.Stderr, "failed to update with tags:", err)
+			return
+		}
+
+		output.PrintNode(cmd.OutOrStdout(), svc, n, jsonFlag)
 	},
 }